Replace usage of "information_schema.tables" with "SHOW TABLES LIKE" #30745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This db table is used to check if the product attributes lookup table exists, but that makes WooCommerce uninstallable in WP.COM without a patch. This commit replaces that usage with a "SHOW TABLES LIKE" statement, which is also consistent with other parts of the code.
Konamiman
requested review from
a team and
jonathansadowski
and removed request for
a team
Contributor
|
@Konamiman could you boil down the testing instructions a little bit? This PR says to follow the testing instructions of #30041, which says to follow the testing instructions of #29190. I just want to make sure I'm understanding the expectations correctly. Here's how I understand things, correct me if my understanding is off:
Is my understanding correct? |
Contributor
Author
|
Sorry, yes, I was a bit lazy on this one. Your assumptions on expectations
are pretty much spot on, but more precisely, for the tools page:
I'f the table exists: you should see two entries, "Regenerate" and "Delete".
I'd the table doesn't exist: there's one single entry, "Create".
El mar., 21 sept. 2021 17:37, jonathansadowski ***@***.***>
escribió:
… @Konamiman <https://github.com/Konamiman> could you boil down the testing
instructions a little bit? This PR says to follow the testing instructions
of #30041 <#30041>, which
says to follow the testing instructions of #29190
<#29190>. I just want to
make sure I'm understanding the expectations correctly.
Here's how I understand things, correct me if my understanding is off:
- Settings > Products > Advanced should exist when the table exists
(and should be missing when it is missing)
- "Regenerate the product attributes lookup table" should appear in Status
> Tools when the table exists (and should be missing when it is
missing)
Is my understanding correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30745 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHE5623MYJR7FOH4DRHP7DUDCREXANCNFSM5EN7DCRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Contributor
|
Awesome, thanks for clarifying! |
jonathansadowski
approved these changes
Sep 21, 2021
jonathansadowski
added
release: add changelog
Contributor
|
Hi @jonathansadowski, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
Konamiman
added
changelog added
and removed
release: add changelog
tammullen
added
testing instructions added
and removed
release: add testing instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#30041 introduced a
check_lookup_table_existsmethod that accesses theinformation_schema.tablestable in order to check if the lookup table exists. However it looks like this is causing issues in WPCOM: an automated code checking script is preventing Woo from being installed for this reason.This pull request changes the mechanism for checking if the table exists to a
SHOW TABLES LIKE, which is consistent with how database table existence is checked in other places of the codebase.How to test the changes in this Pull Request:
Follow the testing instructions of #30041. Specifically, check that the options shown in the tools page and in Settings > Products > Advanced is consistent with the table existing or not.
Other information:
Changelog entry
FOR PR REVIEWER ONLY: