Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Sep 7, 2021

All Submissions:

Changes proposed in this Pull Request:

Closes #29890

How to test the changes in this Pull Request:

  1. Create an order with products, fee and shipping line items. See screenshot below.
  2. Go to the order and click on the delete icon on each of the line items (product, fee and shipping).
  3. For each popup confirmation, ensure the correct text message is shown based on the context of the line item.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Tweak - Add individual item remove notices based on the context of the line item in the order.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@roykho roykho requested review from a team and claudiosanches and removed request for a team September 7, 2021 16:10
@roykho roykho requested review from a team and Konamiman and removed request for a team and claudiosanches September 15, 2021 13:27
@Konamiman Konamiman merged commit 69203f2 into trunk Sep 15, 2021
@Konamiman Konamiman deleted the fix/29890 branch September 15, 2021 15:05
@github-actions github-actions bot added this to the 5.8.0 milestone Sep 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2021

Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

@Konamiman Konamiman added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Sep 15, 2021
@zhongruige zhongruige added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GlobalStep] Incorrect Popup is displayed when user removes tax/Shipping/fee added on "Orders->Add Order" Page

4 participants