-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Added text to be displayed when invalid data is entered into search input field and no search results are found #30641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added text to be displayed when no search results found , fixes issue woocommerce#30588
|
Hey @vedanshujain @andfinally @kloon , I have added this PR #30641 , please review it , thank you |
|
Ok , now I see that the changes I have made are wrong, but how do I know that no search results are being returned |
|
|
@san-coding you should be able to use |
Thanks @vedanshujain , I have made the changes , instead of checking I have also added 0` ) : ?> , so that the message that the message search results for "" is displayed only when please verify and review if my changes are correct, thanks @vedanshujain |
made changes requested in PR woocommerce#30641
Checking sizeof($addons>0) along with !empty($search) to display search results if addons found
|
Hey @vedanshujain , could you please review this |
|
Have added required space and replaced |
|
@vedanshujain , looks like all checks have passed, you may review and merge |
|
@vedanshujain @rodelgc @andfinally someone please review this |
| <?php if ( ! empty( $search ) ) : ?> | ||
| <?php if ( count( $addons ) == 0 ) : ?> | ||
| <h1 class="search-form-title"> | ||
| <?php // translators: search keyword. ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this since there is no placeholder in the string below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly should I remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He is talking about this <?php // translators: search keyword. ?>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have made the changes
|
Thank you , I have made the changes, please review this PR |
|
@kloon @eopws @vedanshujain please review this |
kloon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me now, thanks!
|
@kloon thanks |
|
Requesting a review from the core team before merging just to double check, should be a quick one. |
vedanshujain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @vedanshujain, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
|
Thanks you 👍🏻 |
My reading of the rules is that the label is not necessary, but please let us know if you think we need to add it. Thx! |
|
Hi @san-coding @vedanshujain - there is a slight issue for this PR when there is no search term the error message still displays (ie. on the landing page when you first access Marketplace). To reproduce:
I am happy to open a PR to correct this if you like. Just let me know. |
|
Ohh i will look into this and get back to you soon, can you revert the merge, adding a condition to check if search term exists would be enough i guess |
|
@drjamesj , checkout this file in the trunk branch, maybe it has been solved
|

Added text to be displayed when invalid data is entered into the search input field and no search results found
in
WooCommerce-> Marketplace, fixes issue #30588All Submissions:
Changes proposed in this Pull Request:
Closes # .
How to test the changes in this Pull Request:
Sorry, could not find anything. Try searching again using a different term.Other information:
Changelog entry
FOR PR REVIEWER ONLY: