Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Sep 3, 2021

…oses #30264

All Submissions:

Changes proposed in this Pull Request:

Closes #30264

Things I've thought to do: Refactor the link generator to accept attributes but it seemed overkill for right now unless we will have other links that we need to customize. I know it is quite a catchall at the moment but I think we can reassess once we will have other links in the future.

How to test the changes in this Pull Request:

  1. With no products in your store load the products page. /wp-admin/edit.php?post_type=product.
  2. Scroll down towards the bottom to find the link Browse all extensions.
  3. Click on the link and ensure the page is loaded in a new tab instead of the current tab.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Tweak - Open Browse all extensions link in a new tab.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@roykho roykho requested review from a team and barryhughes and removed request for a team September 3, 2021 15:27
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Confirmed the relevant link now opens in a new tab / has target="blank" applied.

@barryhughes barryhughes added the release: add changelog Mark all PRs that have not had their changelog entries added. [auto] label Sep 3, 2021
@roykho
Copy link
Contributor Author

roykho commented Sep 8, 2021

Hi @barryhughes - was this one waiting on something before merge?

@barryhughes
Copy link
Member

Sorry @roykho—no reason, meant to merge it.

@barryhughes barryhughes merged commit 3ce7d62 into trunk Sep 8, 2021
@barryhughes barryhughes deleted the fix/30264 branch September 8, 2021 19:05
@github-actions github-actions bot added this to the 5.8.0 milestone Sep 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

@zhongruige zhongruige added release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GlobalStep] "Browse all extensions" link fails to open in new tab on Products screen.

4 participants