Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Sep 3, 2021

All Submissions:

Changes proposed in this Pull Request:

Closes #30471

How to test the changes in this Pull Request:

  1. Go to All products page. /wp-admin/edit.php?post_type=product
  2. Mark one of the product as a featured product by clicking on the Star icon.
  3. Then find another product (that is not featured) and click on the Quick Edit link.
  4. Make sure the featured setting is not checked and click on Update.
  5. Find the product you set as featured from step 2 and click on the Quick Edit link.
  6. Ensure the featured checkbox is checked.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix - During product quick edit, the featured setting is sometimes not shown correctly as checked.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@roykho roykho requested review from a team and Konamiman and removed request for a team September 3, 2021 14:54
@Konamiman Konamiman merged commit 25f4aa7 into trunk Sep 6, 2021
@Konamiman Konamiman deleted the fix/30471 branch September 6, 2021 07:38
@github-actions github-actions bot added this to the 5.8.0 milestone Sep 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021

Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

@Konamiman Konamiman added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Sep 6, 2021
@zhongruige zhongruige added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick Edit removes featured product checkbox

4 participants