Skip to content

Marketplace mobile layout fixes #30498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andfinally merged 8 commits into from
Aug 13, 2021
Merged

Marketplace mobile layout fixes #30498

andfinally merged 8 commits into from
Aug 13, 2021

Conversation

@madeincosmos
Copy link
Contributor

@madeincosmos madeincosmos commented Aug 13, 2021

All Submissions:

Changes proposed in this Pull Request:

  • Fix product card on mobile devices so that content doesn't overflow.
  • Change top bar menu to a dropdown menu.

How to test the changes in this Pull Request:

  1. Check out branch on local environment
  2. Go to WooCommerce > Marketplace
  3. Switch to mobile view and make sure product cards look good on all resolutions.
  4. Test the dropdown menu and make sure it's fully functional on all screen sizes, and that the current item is always highlighted.

Screenshots

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@andfinally andfinally changed the title Update/marketplace mobile fixes Marketplace mobile layout fixes Aug 13, 2021
@andfinally andfinally changed the base branch from trunk to update/marketplace-1 August 13, 2021 10:45
@andfinally
Reduced left padding of .marketplace-header on smallest screens, so…
8de3f6b 
… text in it lines up with the breadcrumb menu and section dropdown link.
andfinally
andfinally approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@andfinally andfinally left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvellous, thanks! I fixed some PHPCS issues GH was still complaining about, and changed the base to the feature branch. I also changed the side padding of .marketplace-header so it lines up with the breadcrumb and section menu link on the smallest screens.

@andfinally andfinally added the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Aug 13, 2021
@andfinally andfinally mentioned this pull request Aug 13, 2021
Merged
6 tasks
@andfinally andfinally removed the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Aug 13, 2021
@andfinally andfinally merged commit 68559fa into update/marketplace-1 Aug 13, 2021
@andfinally andfinally deleted the update/marketplace-mobile-fixes branch August 13, 2021 13:00
@andfinally andfinally mentioned this pull request Aug 13, 2021
Merged
7 tasks
@github-actions github-actions bot added this to the 5.7.0 milestone Aug 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

Hi @andfinally, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

@roykho roykho added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Aug 17, 2021
@rodelgc rodelgc added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kloon kloon Awaiting requested review from kloon

@tgglv tgglv Awaiting requested review from tgglv

1 more reviewer

@andfinally andfinally andfinally approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Milestone

5.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@madeincosmos @andfinally @roykho @rodelgc