-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Update locale-info.php #30216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update locale-info.php #30216
Conversation
roykho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Tested well per your instructions. I've left some comments which needs to be addressed and also a question.
roykho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes.
|
@roykho thanks for the approval and merge! |
All Submissions:
Changes proposed in this Pull Request:
Related fix for Automattic/woocommerce-payments#2246.
This PR will add support for other currencies and locale specific settings for WooCommerce, which will also solve the need for locale-currency-country matching when the customer's location is detected via geolocation system, also will be used as a base for the other multi-currency related plugins, e.g. WooCommerce Payments.
It includes the new country and locale data while preserving the original content, with some additional formatting fixes, all obtained from data provided by the CLDR (http://cldr.unicode.org/).
Existing keys still remain the same:
New keys added to the existing country data:
The new countries are:
How to test the changes in this Pull Request:
npm run docker:upto prepare the testing environmentnpm run test:e2eto run the E2E testsManual Test:
Arubaas your country, and finish onboarding. If you have already finished onboarding, you can go to WooCommerce > Orders, then on the above tab drawer, choose Help > Setup Wizard, then click on the Setup Wizard button to re-access the onboarding workflow.WooCommerce > Settings > Generaland on the Currency select, you should seeAruban florin (Afl.)as the selected currency for that store.Other information:
Note The tests will be added separately on this PR: #30350
Changelog entry
Enhancement - Update
locale-info.phpto contain all the countries, currency specs and locale information. #30216