Add labels and allow searching terms in WooCommerce Navigation Link block variations #29772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, they can be searched when adding the Product Category Link and Product Tag Link blocks.
Contributor
Author
|
@frontdevde pinging you for review from our team. We will also need this PR reviewed by somebody from Proton. |
frontdevde
approved these changes
Apr 29, 2021
roykho
approved these changes
May 19, 2021
Contributor
roykho
left a comment
roykho
left a comment
There was a problem hiding this comment.
LGTM! Works as expected. Thanks for the PR.
woocommercebot
added
release: add changelog
roykho
added
the
release: cherry-pick
ObliviousHarmony
added
changelog added
and removed
release: cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce-blocks#4130.
Fixes woocommerce/woocommerce-blocks#4131.
Fixes woocommerce/woocommerce-blocks#4132.
WordPress 5.8 is adding an
item_linkanditem_link_descriptionlabel properties to custom post types and taxonomies, so they can be used to add friendly names to Navigation Link block variations. Notice those variations are created automatically from CPT and taxonomies.In order to get those block variations to work properly, we also need to enable Rest for Product Categories and Product Tags so they can be searched using the UI.
Screenshots
Labels
Rest suggestions
How to test the changes in this Pull Request:
Changelog entry