Update SelectWoo to 1.0.9 and take advantage of data-label support. #29706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Improves A11Y in relation to the billing and shipping state and country fields. Closes #27317.
data-labelattribute.data-labelstring, if provided.☝️ This composite screenshot shows the change in action. Note the tooltips added by MacOS's VoiceOver util, which now is of the format
<Current Value or Placeholder> <Label Text> <Other Items>whereas, previously, we were missing the<Label Text>component (such as "Country / Region").How to test the changes in this Pull Request:
Using the VoiceOver util from MacOS (of course, feel free to use popular alternatives, too):
Other information:
<select>(and therefore the generated SelectWoo dropdown) within the<label>element, and some other permutations, but besides being inconsistent with how we handle other fields it did not improve things when I tested with VoiceOver.Changelog entry