Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Apr 12, 2021

All Submissions:

Changes proposed in this Pull Request:

We want to default store location to US California. This is mainly because WC Pay uses this locale to determine what to advertise.

Closes #29499

How to test the changes in this Pull Request:

  1. You can probably do this locally by deleting some options but I find it easier just to test it on Jurassic Ninja. So set one up.
  2. Pull down this PR and run npm run build:zip to build a zip package to install on your JN site.
  3. After activating the plugin, you will see the Setup Wizard.
  4. Click the link at the bottom to skip it.
  5. Go to /wp-admin/admin.php?page=wc-settings
  6. Ensure the Country / State shows United States (US) - California as the default.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Tweak - Default store location to US California.

@roykho roykho requested review from a team and vedanshujain and removed request for a team April 12, 2021 21:14
@roykho
Copy link
Contributor Author

roykho commented Apr 15, 2021

@vedanshujain in case you missed this.

Copy link
Contributor

@vedanshujain vedanshujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating tests as well.
Sidenote that code standards are failing on old code (but in same files), so going ahead with merge.

@vedanshujain vedanshujain merged commit d79e869 into trunk Apr 16, 2021
@vedanshujain vedanshujain deleted the fix/29499 branch April 16, 2021 11:24
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Apr 16, 2021
@vedanshujain vedanshujain added this to the 5.3.0 milestone Apr 16, 2021
@tammullen tammullen added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default base country as detected location until manually changed

5 participants