Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Mar 26, 2021

All Submissions:

Changes proposed in this Pull Request:

Closes #29359

How to test the changes in this Pull Request:

  1. Go to woocommerce->settings->shipping and add a shipping zone with a shipping method.
  2. After seeing the "Save Changes" button disables, try to navigate away from this page.
  3. Ensure you're not seeing any save changes message pop up from the browser.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix - Unneeded browser popup message of unsaved changes when adding a shipping zone with a shipping method.

@roykho roykho requested review from a team and barryhughes and removed request for a team March 26, 2021 22:13
@roykho roykho added this to the 5.3.0 milestone Mar 26, 2021
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, optionally could add a comment to give some context to the next maintainer.

@barryhughes barryhughes merged commit 90d9dce into trunk Mar 30, 2021
@barryhughes barryhughes deleted the fix/29359 branch March 30, 2021 14:09
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Mar 30, 2021
@tammullen tammullen added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shipping Zone - Save changes button is disabled but unsaved warning is still shown when navigating out after adding a method.

5 participants