Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Mar 25, 2021

All Submissions:

Changes proposed in this Pull Request:

Closes #29323

How to test the changes in this Pull Request:

NOTE: You need to first grunt assets

  1. Enable Twenty Twenty One theme.
  2. Go to Customizer->Colors & Dark Mode and enable dark mode.
  3. Check the Select2 dropdown fields on cart, checkout, my account (edit address) pages.
  4. Ensure when in dark mode, the text is showing correctly.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix - Text not visible in the dropdown fields in Twenty Twenty One theme when in dark mode.

@roykho roykho requested review from a team and vedanshujain and removed request for a team March 25, 2021 14:52
@roykho roykho added this to the 5.3.0 milestone Mar 25, 2021
Copy link
Contributor

@vedanshujain vedanshujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vedanshujain
Copy link
Contributor

an e2e test is failing but looks unrelated. i have restarted it again, we can merge after it passes.

@roykho roykho merged commit f7e38bd into trunk Mar 26, 2021
@roykho roykho deleted the fix/29323 branch March 26, 2021 21:31
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Mar 26, 2021
@tammullen tammullen added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GlobalStep] For Twenty Twenty One theme, when dark mode is enabled "Dropdown" option within the website are only visible when we hovered over it

5 participants