Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Mar 24, 2021

All Submissions:

Changes proposed in this Pull Request:

Created a new function to handle duplicate notices. While this was to address the shipping debug notices, it will also work in general to remove any duplicate notices.

Closes #28914

How to test the changes in this Pull Request:

  1. Setup shipping with a valid zone/method.
  2. Enable shipping debug mode by going to woocommerce->settings->shipping->shipping options
  3. Add several items to the cart and navigate there
  4. You should see the shipping debug message/notice of what zone location was detected.
  5. Try deleting an item from the cart with the X button. After the AJAX process and the item is removed, ensure you are not seeing duplicate shipping debug message/notice.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix - Cart duplicate debug shipping notices in certain situations.

@roykho roykho requested review from a team and Konamiman and removed request for a team March 24, 2021 17:08
@Konamiman Konamiman merged commit 47aa9d7 into trunk Mar 25, 2021
@Konamiman Konamiman deleted the fix/28914 branch March 25, 2021 08:20
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Mar 25, 2021
@Konamiman Konamiman added this to the 5.3.0 milestone Mar 25, 2021
@Konamiman Konamiman changed the title Remove duplicate notices from cart during ajax updates closes #28914 Remove duplicate notices from cart during ajax updates Mar 25, 2021
@tammullen tammullen added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification message not getting cleared on when doing add to cart on cart page

5 participants