Fix/issue 28284 #29044

roykho · 2021-02-05T20:13:22Z

All Submissions:

Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR updates WooCommerce for compatibility with jQuery 3 in preparation of the removal of jQuery Migrate in a future version of WordPress.

closes #28284 #28286

For reference, I am using this documentation here https://jquery.com/upgrade-guide/3.0/ and here https://github.com/jquery/jquery-migrate/blob/master/warnings.md

How to test the changes in this Pull Request:

IMPORTANT NOTE

It is quite difficult or not feasible to test every line changes. You may not even know how or where to try and produce the results. We can only test everything we do know such as critical flows and little tidbits.

There are some gotchas that I've found and will document that here p7bje6-2VM-p2#comment-5896.

Install this plugin and disable jQuery Migrate.
Open your browser's javascript console and look for errors while testing the critical flows.
Go through the critical flows in WooCommerce and verify that they still function.

Changelog entry

Fix - Migrate deprecated jQuery 3 functions.

github-actions · 2021-02-05T20:19:01Z

📦 Artifacts ready for download!

assets/js/jquery-tiptip/jquery.tipTip.js

jonathansadowski · 2021-02-26T03:33:17Z

I pushed a few commit fixing things I found as I was going through this...

I double-checked all of the .bind() and .data() calls, and I think I caught the rest of them... except for a usage of .data() in add-to-cart.js here:

woocommerce/assets/js/frontend/add-to-cart.js

Lines 82 to 84 in dd10ad5

    
           $.each( $thisbutton.data(), function( key, value ) { 
        
           	data[ key ] = value; 
        
           });

I'm not really sure how to address that in a way that would be backwards-compatible without essentially including the entire part of jQuery Migrate that handles data compatibility. If anybody happens to set data using $().data('some-key-with-dashes'), it'll be stored on the data object with the key someKeyWithDashes, and there's not really a clean was to reverse that without just storing that key as well when it's set.

I gave the JS and PHP files another pass — I want to run through them one more time to make sure that nothing was missed.

I also want to give the e2e tests a go with the Test jQuery Update plugin installed to see if they catch anything that I might have missed.

rrennick · 2021-04-19T14:18:53Z

@roykho @jonathansadowski The two source E2E failures are creating shipping methods/zones and order search. Let me know if you'd like me to investigate.

…ax.js

…g jQuery object; was native JS bind)

ObliviousHarmony

Thanks for the great work here, this was a gargantuan effort.

To test this PR I set up a site locally with the plugin disabling jQuery Migrate. I was able to successfully run the E2E suite. After it passed a few compatibility tests as well, I'm happy to report that this PR looks like it works.

After reviewing the code as well, I'm ready to approve it!

nerrad · 2021-06-11T18:15:55Z

assets/js/jquery-tiptip/jquery.tipTip.js

 			if(org_title != ""){
 				if(!opts.content){
-					org_elem.removeAttr(opts.attribute); //remove original Attribute
+					org_elem.prop(opts.attribute, false); //remove original Attribute


@roykho I think this is breaking some extensions using jquery-tiptip (see 693-gh-woocommerce/woocommerce-product-addonsr example).

mikkamp reviewed Feb 18, 2021

View reviewed changes

assets/js/jquery-tiptip/jquery.tipTip.js Outdated Show resolved Hide resolved

Base automatically changed from master to trunk February 25, 2021 22:18

jonathansadowski force-pushed the fix/issue-28284 branch from 569985b to 4cd2bad Compare March 9, 2021 15:29

jonathansadowski force-pushed the fix/issue-28284 branch 2 times, most recently from 08278df to 1701a04 Compare April 13, 2021 04:07

roykho added 22 commits April 28, 2021 16:21

Update deprecated jQuery functions for jquery.payment.js closes #28284

ef57248

Update deprecated jQuery functions for jquery.flot.js

c4c02a2

Update deprecated jQuery functions for jquery.float.resize.js

e4bfbe7

Update deprecated jQuery functions for jquery.serializejson.js

dddd0d6

Update deprecated jQuery functions for jquery.flexslider.js

176cd16

Update deprecated jQuery functions for jquery.flot

ac445e0

Update deprecated jQuery functions for jquery.flexslider.js

6b7b8d7

Update deprecated jQuery functions for jquery.cookie.js

ebdaaa3

Update deprecated jQuery functions for jquery.tiptip.js

a5543fd

Update deprecated jQuery functions for jquery.zoom.js

3d1391f

Update deprecated jQuery functions for jquery.blockui.js

08aa9e3

Update deprecated jQuery functions for api-keys.js

37f7ccc

Update deprecated jQuery functions for backbone-modal.js

13a9dbb

Update deprecated jQuery functions for meta-boxes-coupon.js

6e50fc0

Update deprecated jQuery functions for meta-boxes-order.js

1879749

Update deprecated jQuery functions for meta-boxes-product-variation.js

afb9656

Update deprecated jQuery functions for meta-boxes-product.js

f59c777

Update deprecated jQuery functions for meta-boxes-product.js

4d0df8d

Fixed removeAttribute replacements

58cfd4c

Update deprecated jQuery functions for quick-edit.js

81d6e50

Update deprecated jQuery functions for settings-views-html-settings-t…

d84eb2d

…ax.js

Update deprecated jQuery functions for settings.js

142aad6

roykho and others added 11 commits April 28, 2021 16:26

Update deprecated jQuery functions for meta-boxes-product-variation.js

38cabd2

Update deprecated jQuery functions for meta-boxes-product.js

6522893

Update deprecated jQuery functions for meta-boxes-product.js

a98b27b

Fixed removeAttribute replacements

1710a84

Update deprecated jQuery functions for wc-product-export.js

f4745ed

Update deprecated jQuery functions for wc-product-import.js

1215f19

Revert load function

6a1e3eb

Update deprecated jQuery functions in includes folder

3773679

Correct bind usage in product import and export (bind wasn't targetin…

9e89ac8

…g jQuery object; was native JS bind)

Update cart-fragments.js to remove deprecated jQuery bind function

4e8629e

Address code sniff issues

98b4968

jonathansadowski force-pushed the fix/issue-28284 branch from 1701a04 to 98b4968 Compare April 28, 2021 21:26

jonathansadowski marked this pull request as ready for review April 29, 2021 02:58

jonathansadowski requested review from a team and ObliviousHarmony and removed request for a team April 29, 2021 02:58

ObliviousHarmony approved these changes May 10, 2021

View reviewed changes

ObliviousHarmony added this to the 5.4.0 milestone May 10, 2021

ObliviousHarmony merged commit fd624f7 into trunk May 10, 2021

ObliviousHarmony deleted the fix/issue-28284 branch May 10, 2021 18:38

woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels May 10, 2021

ObliviousHarmony added changelog added and removed release: add changelog Mark all PRs that have not had their changelog entries added. [auto] labels May 14, 2021

juliaamosova added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels May 17, 2021

jonathansadowski mentioned this pull request May 19, 2021

Ensure WooCommerce is compatible with jQuery 3 #28286

Closed

jonathansadowski mentioned this pull request Jun 9, 2021

Update former uses of jQuery.trim to work properly with non-string types #30074

Merged

6 tasks

nerrad reviewed Jun 11, 2021

View reviewed changes

ObliviousHarmony mentioned this pull request Jun 11, 2021

Tooltips return "false" #30089

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/issue 28284 #29044

Fix/issue 28284 #29044

Uh oh!

roykho commented Feb 5, 2021 •

edited by jonathansadowski

Loading

Uh oh!

github-actions bot commented Feb 5, 2021

Uh oh!

Uh oh!

jonathansadowski commented Feb 26, 2021 •

edited

Loading

Uh oh!

rrennick commented Apr 19, 2021

Uh oh!

ObliviousHarmony left a comment

Uh oh!

nerrad Jun 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Fix/issue 28284 #29044

Fix/issue 28284 #29044

Uh oh!

Conversation

roykho commented Feb 5, 2021 • edited by jonathansadowski Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Uh oh!

github-actions bot commented Feb 5, 2021

Uh oh!

Uh oh!

jonathansadowski commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rrennick commented Apr 19, 2021

Uh oh!

ObliviousHarmony left a comment

Choose a reason for hiding this comment

Uh oh!

nerrad Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

roykho commented Feb 5, 2021 •

edited by jonathansadowski

Loading

jonathansadowski commented Feb 26, 2021 •

edited

Loading