Fix price filtering when there are variations. #29043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The price filtering query wasn't working properly when there are variations with different prices: if at least one variation was
outside of the price range but other were inside, the product wasn't being listed.
This pull request fixes the generation of the
whereclause inWC_Query->price_filter_post_clausesto account for this case.Closes #25261
How to test the changes in this Pull Request:
Create a variable product having two variations with prices 1000 and 1200. Install the price filtering widget and try the following combinations of min and max price:
The product should not be listed in the cases 1 and 7, in all the other cases it should be listed.
Note: if you don't have products with a price higher than 1220 you won't be able to use the widget for the last three combinations, but you can just modify the query string and reload manually.
Note: that's not a complete fix and will 100% work only when the "Hide out of stock products" option is disable. See this comment in the original issue.
Other information:
Changelog entry