Skip to content

Adjust spacing and font sizes for Twenty Twenty-One #28827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathansadowski merged 1 commit into from
Jan 20, 2021
Merged

Adjust spacing and font sizes for Twenty Twenty-One #28827

jonathansadowski merged 1 commit into from
Jan 20, 2021

Conversation

@jffng
Copy link
Contributor

@jffng jffng commented Jan 15, 2021

This pull request makes some style changes specific to Twenty Twenty-One. See: pNEWy-duL-p2#comment-52564 for more background.

Closes Automattic/themes#3029.

Before After
Screen Shot 2021-01-15 at 12 40 45 PM Screen Shot 2021-01-15 at 12 39 48 PM

How to test the changes in this Pull Request:

  1. Check out this PR and rebuild the styles
  2. Navigate between an Account Page, Checkout page, and non Woo page
  3. Ensure the heading titles are consistent, product and checkout pages look okay

Changelog entry

  • Makes entry heading padding more consistent with the rest of the theme
  • Reduces the maximum thumbnail size of the image displayed in the cart
  • Reduces entry

@peterfabian peterfabian requested review from a team, claudiosanches and jonathansadowski and removed request for a team January 20, 2021 18:07
@peterfabian
Copy link
Contributor

peterfabian commented Jan 20, 2021

GH bot selected @claudiosanches to review, but cc'ing @jonathansadowski as he worked on this quite a bit recently. Can you folks coordinate who can review this, please?

@jonathansadowski
Copy link
Contributor

jonathansadowski commented Jan 20, 2021

@claudiosanches, I'll grab this

@claudiosanches claudiosanches removed their request for review January 20, 2021 19:24
jonathansadowski
jonathansadowski approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tweaks. Compared the before/after of each, and they're all marked improvements 👍

@jonathansadowski jonathansadowski merged commit 1f430fc into woocommerce:master Jan 20, 2021
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 20, 2021
@jffng
Copy link
Contributor Author

jffng commented Jan 20, 2021

Thanks for the review @jonathansadowski !

@jffng jffng deleted the add/twentytwentyone-style-tweaks branch January 20, 2021 21:12
@roykho roykho added this to the 5.1.0 milestone Feb 11, 2021
@zhongruige zhongruige added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonathansadowski jonathansadowski jonathansadowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

TT1: Woo Fixes

6 participants

@jffng @peterfabian @jonathansadowski @roykho @woocommercebot @zhongruige