Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Jan 13, 2021

… status closes #27791

All Submissions:

Changes proposed in this Pull Request:

Closes #27791

How to test the changes in this Pull Request:

  1. Go through checkout and use BACS as payment gateway so the initial order status is on-hold.
  2. Check your email and ensure you're seeing the New Order email to the admin.
  3. Change the order status to pending payment. At this point there shouldn't be any emails sent.
  4. Change the order status to completed.
  5. Check your email and ensure the New Order email is not sent again.
  6. Go back to the order and use the Order Actions to resend the new order notification.
  7. Check your email and ensure now you see the New Order email come through.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

  • Fix - Duplicate New Order emails being sent when changing order status.

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@roykho roykho requested review from a team and jonathansadowski and removed request for a team January 13, 2021 22:19
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jonathansadowski jonathansadowski added this to the 5.0.0 milestone Jan 14, 2021
@jonathansadowski jonathansadowski merged commit e855209 into master Jan 14, 2021
@jonathansadowski jonathansadowski deleted the fix/issue-27791 branch January 14, 2021 15:36
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 14, 2021
@claudiosanches claudiosanches added release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate emails if you set the order to cancelled or pending payment

5 participants