-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add notice to deprecate old reports closes #27789 #28799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <?php | ||
| /* translators: 1: Link URL */ | ||
| echo wp_kses_post( sprintf( __( 'With the release of WooCommerce 4.0, these reports are being replaced. There is a new and better Analytics section available for users running WordPress 5.3+. Head on over to the <a href="%1$s">WooCommerce Analytics</a> or learn more about the new experience in the <a href="https://docs.woocommerce.com/document/woocommerce-analytics/" target="_blank">WooCommerce Analytics documentation</a>.', 'woocommerce' ), esc_url( wc_admin_url( '&path=/analytics/overview' ) ) ) ); | ||
| ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've submitted a rewording of the docs to the following new text:
With the release of WooCommerce 4.0 in March 2019, these reports are deprecated and won’t receive further updates.
There is a new and better Analytics section available for users running WordPress 5.3+. Learn more about the new reports and admin experience in the WooCommerce Analytics documentation.
So if it gets approved, we can also change it here, but let's leave it until it gets approved. Strings can be updated also later in the process.
|
I've updated the code to show up on top of the page which will show on every reports page. This should be more clear and consistent across the pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peterfabian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, thanks!
|
I've added label release highlight here as I think we should explicitly mention this in the dev blog post. |
|
@roykho if you are removing Legacy Reports, what about the “Profit” reports that are part of the Cost of Goods plugin? I could be wrong but I haven’t seen anything related to Profit or Inventory Value in the new Reports. |
|
Hi @jsmusiker - we're not removing it at this time. It is a soft deprecation. Meaning we're urging people to start using the newer analytics pages. The legacy reports will still live around either under a flag in the future or could be a separate plugin but we will decide that later. |
|
Ok @roykho thank you for replying! Just making sure you all are aware of the Cost of Goods Reports! I feel like it’s not that well known that the Reports are even there. And didn’t want them to be lost, because they are very helpful. Just so we are on the same page, I’m talking about the Cost of Goods Plugin sold on WC, but Developed by SkyVerge. |


All Submissions:
Changes proposed in this Pull Request:
Closes #27789
How to test the changes in this Pull Request:
Other information:
Changelog entry