Skip to content

Conversation

@roykho
Copy link
Contributor

@roykho roykho commented Jan 12, 2021

All Submissions:

Changes proposed in this Pull Request:

Closes #27789

How to test the changes in this Pull Request:

  1. Go to the "legacy" woocommerce->reports.
  2. Ensure you're seeing a notice that the report is being replaced with links to documentation and the new analytics page.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Tweak - Notice to deprecate legacy reports in favor of the newer analytics page.

@roykho roykho requested a review from peterfabian January 12, 2021 15:40
@claudiosanches claudiosanches added this to the 5.0.0 milestone Jan 12, 2021
Copy link
Contributor

@peterfabian peterfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

One small issue: it doesn't show up for me on the Stock report. I think we should include it over there, too.
Screenshot 2021-01-13 at 15 45 51

<?php
/* translators: 1: Link URL */
echo wp_kses_post( sprintf( __( 'With the release of WooCommerce 4.0, these reports are being replaced. There is a new and better Analytics section available for users running WordPress 5.3+. Head on over to the <a href="%1$s">WooCommerce Analytics</a> or learn more about the new experience in the <a href="https://docs.woocommerce.com/document/woocommerce-analytics/" target="_blank">WooCommerce Analytics documentation</a>.', 'woocommerce' ), esc_url( wc_admin_url( '&path=/analytics/overview' ) ) ) );
?>
Copy link
Contributor

@peterfabian peterfabian Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a rewording of the docs to the following new text:

With the release of WooCommerce 4.0 in March 2019, these reports are deprecated and won’t receive further updates.
There is a new and better Analytics section available for users running WordPress 5.3+. Learn more about the new reports and admin experience in the WooCommerce Analytics documentation.

So if it gets approved, we can also change it here, but let's leave it until it gets approved. Strings can be updated also later in the process.

@roykho
Copy link
Contributor Author

roykho commented Jan 13, 2021

I've updated the code to show up on top of the page which will show on every reports page. This should be more clear and consistent across the pages.

@roykho roykho requested a review from peterfabian January 13, 2021 16:19
Copy link
Contributor

@peterfabian peterfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can see it being displayed on all the required pages 👍 (and not on others).

Being at the top, though, it overlaps with Help button. Can you please make it not overlap?
Screenshot 2021-01-14 at 11 36 03

@roykho roykho requested a review from peterfabian January 14, 2021 13:26
Copy link
Contributor

@peterfabian peterfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, thanks!

@peterfabian peterfabian merged commit 02a2bba into master Jan 14, 2021
@peterfabian peterfabian deleted the fix/issue-27789 branch January 14, 2021 18:05
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 14, 2021
@peterfabian peterfabian added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Jan 14, 2021
@peterfabian
Copy link
Contributor

I've added label release highlight here as I think we should explicitly mention this in the dev blog post.

@claudiosanches claudiosanches removed the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Jan 18, 2021
@jsmusiker
Copy link

@roykho if you are removing Legacy Reports, what about the “Profit” reports that are part of the Cost of Goods plugin? I could be wrong but I haven’t seen anything related to Profit or Inventory Value in the new Reports.

@roykho
Copy link
Contributor Author

roykho commented Feb 10, 2021

Hi @jsmusiker - we're not removing it at this time. It is a soft deprecation. Meaning we're urging people to start using the newer analytics pages. The legacy reports will still live around either under a flag in the future or could be a separate plugin but we will decide that later.

@jsmusiker
Copy link

Ok @roykho thank you for replying! Just making sure you all are aware of the Cost of Goods Reports! I feel like it’s not that well known that the Reports are even there. And didn’t want them to be lost, because they are very helpful. Just so we are on the same page, I’m talking about the Cost of Goods Plugin sold on WC, but Developed by SkyVerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: highlight Issues that have a high user impact and need to be discussed/paid attention to.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notice to Reports page to use Analytics instead

6 participants