-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Ensure the orders status is reverted correctly when restoring it. #28690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests fail, but I think it's because I branched from master. Should I have branched from stable (4.8?) |
|
The code looks good to me and the issue is fixed for the orders. =) |
|
Hi @kevinruscoe - could you please also make this work for products as well? |
… upon being restored.
|
@roykho All done. The post type 'product' is now included in the list of post types that should revert their status correctly when being restored. |
roykho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment but otherwise looks good.
roykho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
All Submissions:
Changes proposed in this Pull Request:
As per #28652, WP5.6 defaults all restored post to the "draft" status. They have provided a filter to override this, and saves the previous status to the DB. This ensure restored orders and products are correctly put back to their previous status.
Closes #28652 .
How to test the changes in this Pull Request:
Also:
Other information:
Changelog entry