Skip to content

Conversation

@tanvirulhaque
Copy link
Contributor

@tanvirulhaque tanvirulhaque commented Dec 29, 2020

All Submissions:

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

  1. Create a new product and go to the Attributes tab and add an attribute from the existing attributes.
  2. Select all attributes item by pressing the "Select all" button then press the "Select none" button to remove them.
  3. Again try to select all attributes items by pressing the "Select all" button then you can see all attributes are not selecting anymore.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix: Attributes on Edit Product page - "Select all" not working after "Select none" used

On the product edit once you press the "Select all" button 1st time it works fine, but if you remove all attributes items by pressing the "Select none" button then again if you want to select all attributes items by pressing the "Select all" button it will not work anymore. Here is the reproduced video https://www.loom.com/share/ec45b2c5360945c589eb202c2602c28b

Copy link
Contributor

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@roykho roykho merged commit e0be4b0 into woocommerce:master Jan 8, 2021
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 8, 2021
@roykho roykho removed the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Jan 8, 2021
@claudiosanches claudiosanches added this to the 5.0.0 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants