Skip to content

Conversation

@tyrann0us
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Invert “if” statement to reduce nesting level in \WC_Shipping::calculate_shipping_for_package. This is generally regarded as a plus because it makes methods easier to understand (and indeed, many static analysis tools provide a measure of this as one of the indicators of code quality).

Note that GitHub does not properly display the diff, because most changes only affect the indentation.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Invert “if” statement to reduce nesting level in \WC_Shipping::calculate_shipping_for_package.

Copy link
Contributor

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the help!

@roykho roykho merged commit c6f6d04 into woocommerce:master Jan 5, 2021
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 5, 2021
@roykho roykho removed release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 5, 2021
@tyrann0us tyrann0us deleted the patch-2 branch January 5, 2021 20:33
@claudiosanches claudiosanches added this to the 5.0.0 milestone Jan 15, 2021
@claudiosanches claudiosanches added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants