I tried the test steps but when I click the "Update WooCommerce database" button I get a "The link you followed has expired" error... am I doing something wrong?

@Konamiman - are you triggering a new notice? As in this is not a notice that was already in the database unactioned before this PR?

@roykho Yes, I'm following the testing steps from the PR description: manually modify the db version in the options table, then load the admin page in the site and click "Update database", that's all.

@Konamiman - I know you're following the steps however since I can't see, I have to make sure on a few keys steps. Have you have WC Admin activated as separate plugin and checked out this PR woocommerce/woocommerce-admin#5827 ?

Sorry, totally my fault, I hadn't seen that prerrequisite line 🤦🏻‍♂️

I've now been able to trigger the db update, however after it finishes and I click "Thanks" I get the "expired link" error again. Same if I retry, and the third time the banner has disappeared (including the banner in the other session).

Hmmm I've not seen the "expired link" error in my testing. Only that sometimes the banner doesn't disappear right away on first click and that is normal. But it should definitely disappear after second click after a page refresh.

Hey @jonathansadowski - sorry to wrangle you in here but I need a second tester to see if y'all are both having the issues testing this PR as described by @Konamiman Thanks!

@roykho I'm having the same issue as @Konamiman

When I try and dismiss this notice:

I see this error:

Clicking on "please try again" displays the notice again.

Clicking on the notice dismissal shows "please try again" again.

Clicking on it the last time does dismiss the notice.

@jonathansadowski - Thanks for testing. Would you happen to know the URL link to the dismissal button? I want to see if it is formatted correctly.

Thanks for testing. Would you happen to know the URL link to the dismissal button? I want to see if it is formatted correctly.

@roykho, sorry for the delay in responding.

After I load the dashboard in the incognito window, the link in the main window is to: /wp-admin/admin.php?page=wc-admin&do_update_woocommerce=true&wc-hide-notice=update&_wc_notice_nonce=A

The error message's try again link is: /wp-admin/admin.php?page=wc-admin&do_update_woocommerce=true&wc_db_update_nonce=B (with a different nonce than before)

When I see the dialog again after the try again link fails, that button's nonce is again /wp-admin/admin.php?page=wc-admin&do_update_woocommerce=true&wc-hide-notice=update&_wc_notice_nonce=A (with the same nonce as the dialog before, but different than the try again link)

The error message that the link has expired again links to: /wp-admin/admin.php?page=wc-admin&do_update_woocommerce=true&wc_db_update_nonce=B (same nonce as the previous try-again link)

Finally, the link in the incognito window (which I didn't click) is: /wp-admin/admin.php?page=wc-admin&wc-hide-notice=update&_wc_notice_nonce=C (with a different nonce than any of the previous)

Ok I think I found the culprit. The query arg do_update_woocommerce sometimes persists in the query when you stay on the same page and just clicked refresh to get the "Thanks for updating" notice to show. In my testing, I clicked away from that page hence that query arg isn't there and hence I couldn't reproduce the issue y'all are seeing. So I pushed up a change to remove this query arg when showing the "Thanks for updating" notice.

Could y'all please give this another go? @Konamiman @jonathansadowski

I ran into an interesting issue while testing this. I'm a bit puzzled as to how it could be related to this PR, but let me describe how I've been able to reproduce it:

1. Started with a brand-new WordPress site with this branch checked out, built, and activated. I skipped the on-boarding wizard.
2. Built and activated the branch from Add a nonce check function when preparing note response woocommerce-admin#5827.
3. Went to WooCommerce dashboard (where I left the task list was entirely uncompleted).
4. Open the network inspector and have it monitoring requests.
5. Updated the woocommerce_db_version option to 4.4.0 as described in the original test plan. I used wp option update woocommerce_db_version 4.4.0.
6. Reloaded the page, and clicked on Update WooCommerce database.
7. Reload the page after the update starts. Afterward, I noticed hundreds of requests in the network inspector — they appear to be trying to update the task list. None of them had a response.
   

Switching from this branch to master (and reloading the Dashboard), back to this branch seemed to resolve the issue for me.

I repeated the above steps, again starting on a brand new site, except on the master branch of WC / main branch of WCA, and wasn't able to reproduce the same issue.

Not sure of this is some symptom of how I'm testing this, or some weird obscure thing, so I figure I'd drop it here with the steps I used to recreate it. @Konamiman, could you see if you're able to reproduce the issue I ran into?

Hi @roykho, after your update it seems to work as expected for me (I had to reload a couple of times for the notice to disappear but that's expected according to your description). I'll now check what @jonathansadowski has found.

Hi @jonathansadowski, I haven't been able to reproduce the hundreds of network requests issue locally.

Hi @Konamiman - thanks for testing and approving. Could you please also approve this one here that is linked woocommerce/woocommerce-admin#5827

I'm a little concerned because of the nature of the issue I ran into, but if it doesn't worry you, and nobody else can reproduce it, I'm happy to create a new issue if I still run into it after this is merged.

Hi @jonathansadowski @Konamiman - sorry to rope y'all in on this again. So after speaking with Isotope, we found a suitable hook to use from WC Admin to achieve the same results. This means we don't need to make any changes over on WC Admin side. So basically I just ported the code I've added from there to here. It works the same way as before. Could y'all please review again?