Update lostpassword_post action and add missing parameter
#28467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lostpassword_post` is a WP action that is duplicated in WooCommerce to replicate the functionality to retrieve user password in the 'My Account' pages. WP recently added the variable `$user_data` as a second parameter to this action (WordPress/WordPress@a6cecef). This commit simply copies this change to the version of the action that we maintain. Similar to what was done in 1a99235 when a first parameter as added to the action in WP and we had to do the same in WC core.
rodrigoprimo
requested review from
a team and
Konamiman
and removed request for
a team
Konamiman
approved these changes
Dec 2, 2020
woocommercebot
added
release: add changelog
vedanshujain
removed
the
release: add changelog
juliaamosova
added
testing instructions added
and removed
release: add testing instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
lostpassword_postis a WP action that is duplicated in WooCommerce to replicate the functionality to retrieve user password in the 'My Account' pages. WP recently added the variable$user_dataas a second parameter to this action (WordPress/WordPress@a6cecef). This commit simply copies this change to the version of the action that we maintain. Similar to what was done in 1a99235 when a first parameter was added to the action in WP and we had to do the same in WC core.Closes #28428
How to test the changes in this Pull Request:
/my-account/lost-password/still works.lostpassword_postis called via/my-account/lost-password/any functions hooked to it will receive two parameters ($errorsand$user_data).Changelog entry