Fix incorrect adjustment of post count in WC_Query #27175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26260 introduced a handler for 'found_posts' filter in WC_Query class in order to adjust the count depending on the visibility of variation products. However the handler incorrectly assumed that the filter was triggered only when listing products, when actually it's also triggered for any post type e.g. pages. In these cases the post count was set to zero, which caused bugs. Now the handler starts with the originally supplied posts count, and only decrements it when a post is a product AND is not visible.
Konamiman
added
the
release: cherry-pick
claudiosanches
suggested changes
Jul 30, 2020
Contributor
claudiosanches
left a comment
claudiosanches
left a comment
There was a problem hiding this comment.
The code looks good, I left one note to fix a small coding standard issue
Fix small coding standards issue. Co-authored-by: Claudio Sanches <[email protected]>
Contributor
Author
|
@claudiosanches Thanks for the fix suggestion, I applied it. |
woocommercebot
added
release: add changelog
claudiosanches
removed
the
release: add testing instructions
Konamiman
added
cherry picked
and removed
status: approved
release: cherry-pick
Konamiman
added a commit
that referenced
this pull request
Sep 9, 2020
This commit reverts the functionality introduced in PR #26260 (later refined by #27175, #27190, #27508) in which filtering by attribute using the layered nav widget was improved to handle the cases of variations out of stock. The revert is a response to the numerous problems reported by users in Woo 4.4 and 4.5 Not all the code has been reverted, only the code that resulted in visible functionality changes. Thus, the code that generates term relationships for variations is still in place to keep database consistency and to keep the reverting changes to the minimum needed.
6 tasks
Konamiman
added a commit
that referenced
this pull request
Sep 9, 2020
This commit reverts the functionality introduced in PR #26260 (later refined by #27175, #27190, #27508) in which filtering by attribute using the layered nav widget was improved to handle the cases of variations out of stock. The revert is a response to the numerous problems reported by users in Woo 4.4 and 4.5 Not all the code has been reverted, only the code that resulted in visible functionality changes. Thus, the code that generates term relationships for variations is still in place to keep database consistency and to keep the reverting changes to the minimum needed.
jonathansadowski
pushed a commit
that referenced
this pull request
Sep 10, 2020
This commit reverts the functionality introduced in PR #26260 (later refined by #27175, #27190, #27508) in which filtering by attribute using the layered nav widget was improved to handle the cases of variations out of stock. The revert is a response to the numerous problems reported by users in Woo 4.4 and 4.5 Not all the code has been reverted, only the code that resulted in visible functionality changes. Thus, the code that generates term relationships for variations is still in place to keep database consistency and to keep the reverting changes to the minimum needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#26260 introduced a handler for the
found_postsfilter in theWC_Queryclass in order to adjust the count depending on the visibility of variation products. However the handler incorrectly assumed that the filter was triggered only when listing products, when actually it's also triggered for any post type e.g. pages. In these cases the post count was set to zero, which caused bugs (e.g. orders list appeared empty in customer profiles).Now the handler starts with the originally supplied posts count, and only decrements it when a post is a product AND is not visible.
Closes #27162.
How to test the changes in this Pull Request:
Other information:
Changelog entry
Not needed since the bug was introduced in 4.4 beta 1 and the fix will be included in the final release.