Added the parent's SKU to product searches for variations #27171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the parent's SKU is used when the variation does not have one, we should fall back when searching for consistency.
Konamiman
approved these changes
Aug 6, 2020
rrennick
reviewed
Aug 7, 2020
rrennick
previously requested changes
Aug 7, 2020
Contributor
rrennick
left a comment
rrennick
left a comment
There was a problem hiding this comment.
@ObliviousHarmony This looks great except the nitpick in the DB prepare.
jonathansadowski
approved these changes
Aug 10, 2020
Contributor
jonathansadowski
left a comment
jonathansadowski
left a comment
There was a problem hiding this comment.
Nice work. 👍
I added a note to the comment re: numbered arguments. I agree that it's best to leave the non-numbered arguments for now.
Contributor
Author
|
Noting that the failing check is the nightly build failures fixed in master |
woocommercebot
added
release: add changelog
juliaamosova
added
status: testing instructions added
and removed
release: add testing instructions
rodrigoprimo
added a commit
that referenced
this pull request
Dec 2, 2020
This commit replaces double quotes with single quotes inside a MySQL query to avoid a syntax error when the SQL mode ANSI_QUOTES is enabled in MySQL. When this mode is enabled, MySQL treats double quotes as identifiers (like the backtick character) instead of as string delimiters. Before this change, sites running with this mode enabled wouldn't be able to add products to orders created manually in the admin as the modified query would fail (other places that also use product search including variations would fail as well). The commit that introduced this issue shipped in WC 4.5.0 (see #27171).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
When a variation has no SKU filled out it will default to the parent's in most cases. A caveat here however is that searching does not take this behavior into consideration. This PR adds a join to the product search for the parent's lookup table for variations and checks the SKU of the parent when the child does not have one entered.
I also considered making this change in
get_data_for_lookup_table()but it seemed like invalidating the entire table would be problematic and theproduct_idis already indexed on the lookup table.Closes #25543.
How to test the changes in this Pull Request:
parent-skuandchild-skuon ONE of the children.parent-sku. Without the PR no variations will be visible, with the PR, the variation that has no SKU will show up.child-skuand note both with and without the PR the variation with the SKU will show up.Other information:
Changelog entry