Skip to content

Conversation

@claudiosanches
Copy link
Contributor

@claudiosanches claudiosanches commented Jul 29, 2020

WP 5.5 doesn't introduce a tag inside metaboxes headings

All Submissions:

Changes proposed in this Pull Request:

There's no "Product type" dropdown using on WordPress 5.5-RC1-48681:

product

This happens because WP Core changed the heading of meta boxes, before used to be something like <h2><span>Product Data</span></h2>, but on WP 5.5 it changed to <h2>Product Data</h2>

Closes #27167.

How to test the changes in this Pull Request:

  1. Install WP 5.5, you can install using WP-CLI: wp core update --version=nightly --force
  2. Go to wp-admin/post-new.php?post_type=product
  3. Check that there's no "Product type" dropdown or the "Virtual" and "Downlodable" checkboxes.
  4. Checkout to this branch and run grunt assets
  5. Go back to wp-admin/post-new.php?post_type=product and check if it's all fixed now.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fix - "Product type" dropdown missing from Product's data meta box on WP 5.5

WP 5.5 doesn't introduce a <span> tag inside metaboxes headings
@Konamiman Konamiman added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Jul 30, 2020
Copy link
Contributor

@jonathansadowski jonathansadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the missing dropdown. Nice work. 👍

@claudiosanches claudiosanches merged commit 891a0cf into master Jul 30, 2020
@claudiosanches claudiosanches deleted the fix/27167 branch July 30, 2020 19:38
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jul 30, 2020
@claudiosanches claudiosanches removed the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Jul 30, 2020
@Konamiman Konamiman added cherry picked and removed status: needs review release: cherry-pick Commits from this PR also needs to be added to current release branch. release: add changelog Mark all PRs that have not had their changelog entries added. [auto] labels Jul 31, 2020
@junaidtk
Copy link

#27381 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable Products broken in WC 4.3.1 and WP 5.5RC1(also with WC 4.4 Beta and WP 5.5RC1)

6 participants