Removed the notice for untested minor version updates #26685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
With the increased cadence of releases it becomes necessary that we address the
WC tested up toheader's usefulness. It isn't practical to require everyone to update their extensions every month, especially given that we are only doing backwards compatible minor releases. The only case I can think of where we might want to check the minor version is if the Stable tag on Core is downgraded, but due to the naming of the header, this doesn't make any sense.I considered making this a wildcard of some kind but I think most would bind to a full major version anyway and so this isn't worth the time to add it. As an aside, the tests in
plugin-updates.phpseem to indicate that a header ofWC tested up to: 4would apply to the entire major version cycle, so wildcards already exist!Closes #26248
How to test the changes in this Pull Request:
woocommerce.phpheader to4.0.0and the version string inincludes/class-woocommerce.phpto4.0.0. Without the PR there is a notice for "Version Test Plugin" under the WooCommerce Update on the plugins page. With the PR, the notice does not appear.3.9.0. Also change the tested header in the plugin you created above to3.9.0as well. Both with and without the PR the plugin update will list the notice for the plugin as a major update.As a bonus, try doing all of the above without this PR but the tested version as a major only.
WC tested up to: 3when looking at the major update andWC tested up to: 4when looking at the minor update. We've always supported wildcards 😄Other information:
Changelog entry