-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Product stock adjustments with manual order line item changes #22329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I still miss the way to easily highlight lines when picking items for an order. Say you have 20 items to get from different places. It's great if you can see the progress just by clicking the lines you've picked so far. Makes sense? |
Maybe you can create a separate issue just for a highlighting function as this has got nothing to do with stock management? |
This comment has been minimized.
This comment has been minimized.
See #21754 (comment) |
|
Having lines that highlight on click will likely cause confusion as to what they are doing or what is happening. @ben72 Sounds like a potential extension, marking items as picked in a way that persists across page loads. Could be line item meta data. |
|
@windsorraw Ill reply in the issue. |
|
I really like these changes. Great work! FYI I think this PR covers #22107 as well. |
|
@mikejolley Sounds reasonable if few people use it like that. I'm just reacting as features I use go away.. |
|
@mikejolley just wondering, would it possible to maybe include product exchange with this new way of editing order lines? E.g. customer orders blue socks, shop runs out of blue socks and asks customer if red socks are ok. |
|
@mikejolley oh and one more thing which disappeared with removing the line selection: |
|
@mikejolley Nice job. Just wondering if the DELETED, on item 1, includes trashed orders or it would be just for permanent deleted orders. *Edit: Just realized that you meant deleted products from the orders. Should products also be restocked when moving to trash orders? |
|
Interesting. For what it's worth I too really miss the hilighted line feature. I found it really useful. Would this work for say, lost orders whereby you need to resend in full? Before the update you could select multiple items and click a single button to increase or reduce stock. This was also useful for exchanges (which I've never found an easy way to do, but that's another conversation.. :)) or having to send out replacement items that were say faulty or damaged. |
No, see that moving an order to trash doesn't only means that you want to restock all your products, sometimes is just to remove from your database.
Probably in WooCommerce 3.6. |
claudiosanches
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Will this be available as a standalone release so we can get this fix without introducing new bugs from 3.6? |
|
@davidlonguk Nope but feel free to copy paste from the PR and introduce new bugs yourself :p This PR doesn't fix bugs, it's new functionality, thats why it wasn't added to a 3.5.x fix release. We'll be tagging 3.6 in a few days. There are other fixes coming in 3.6 and performance enhancements you may also need. You're welcome to help beta test to ensure no new bugs exist a launch :) |
|
@mikejolley :) I may well just do that. I see your point about it being new functionality but we are using it to resolve a problem introduced in 3.5 hence reference to bugs. Looks like our choices are to roll back, patch with this new feature or make our own solution so we will try copying your PR as our first choice. |
|
Is there any way to prevent stock change on orders with specific order statuses? I'm reading through the merged commits but I don't see any hooks to change the new functionality. For example, if an order had a custom status like |
|
+1 on filters for preventing stock change on specific order statuses |
Do you already know how to fix it? Same problem here.. |
|
@LeonWesten We are going to be making our plugin that will restore previous behaviour (so there are stock Up/Down buttons ) as we need it for several of our actions that include disabling a line item but not an entire order so we don't have an order status change. If the community would find it useful we can make it publicly available but it's 6-8 weeks out. |
|
Rather than make a plugin, why not create a PR that adds hooks to this code? If I have time this week, I'll see if I can draft up one. |
Yes, please.. |
|
@tldawson That sounds great - I hope it is is accepted but I think that woo have plans to go in a different direction with the stock levels automatically changing when you add/remove line items from an order in a future update rather than going back to manual. We require manual as we have cases where line items remain but we need to increase stock. |
|
I see no reason why they would reject a thoughtful PR that adds hooks to this code. Hooks are the heart of WordPress and Woocommerce's extensibility. |
|
Is there already a solution for this problem? |
|
Being able to click and (highlight) multiple items in the order and then increase or decrease stock is essential. Doing them one by one is tedious. |
|
Who do I have to PAY to get the Reduce Stock & Increase Stock Buttons back in the order? |
1 similar comment
|
Who do I have to PAY to get the Reduce Stock & Increase Stock Buttons back in the order? |
This is an attempt to improve #21754 to try avoiding reverting to #22012.
Reasoning explained in the issue comment here.
This makes 3 main changes:
Everything else is the same. Automated stock events during status change will not double reduce anything because the amounts are stored per line item.
This PR could use feedback from the users in #21754 before merge. I'd recommend for 3.6.
Changelog entry