Skip to content

Conversation

@mikejolley
Copy link
Member

@mikejolley mikejolley commented Mar 21, 2018

These are some changes to help us support infinite scroll in Jetpack.

Specifically this:

  • Ensures orderby cannot be empty on a clean install
  • Rather than unhooking product query after wp, or after it runs, it only unhooks after pre_get_posts has worked it’s magic.

The queries ran by infinite scroll run too late without these changes leading to odd results.

True compatibility also requires some changes in Infinite scroll so this is not testable alone.

cc @tiagonoronha

Copy link
Contributor

@tiagonoronha tiagonoronha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants