Skip to content

Investigate display of the "change address" link in the cart block #42280

@mikejolley

Description

@mikejolley

We've had a few issues around the visibility of the change address link under the cart block and need to investigate what could lead to this happening

Tickets:

There are also some things that were worked on in the past seemingly missing from the current build, for example this change from @tarunvijwani which doesn't actually exist in trunk:

No, if there is any shipping method that is applicable for all the shipping locations then it will not display the shipping calculator at all. This was discussed in the woocommerce/woocommerce-blocks#8141 (comment)

woocommerce/woocommerce-blocks#9025 (comment)

Tarun is creating an RFC for this, but my suggestion would be to:

  • Check that the "change address" button displays under all circumstances if enabled at block level. If a merchant has a setup which would make that redundant (e.g. one shipping zone) I feel we should leave it to them to disable the link rather than implement logic that makes it behave different to the settings
  • Ensure the block level display setting syncs up to the global setting. We could discuss removing or hiding the global setting to avoid confusion here
  • Check that extensions do not have the power to remove the link
  • Add unit tests that cover a variety of carts and confirm the link is active

cc @ralucaStan for visibility

Metadata

Metadata

Assignees

Labels

BugThe issue is a confirmed bug.CartIssues related to the cart.RubikStore API checkout endpoints, Mini-Cart, Cart and Checkout related issuesblock: cartIssues related to the cart block.type: refactorThe issue/PR is related to refactoring.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions