-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Closed
Labels
KirigamiWC Store Editing (FSE)WC Store Editing (FSE)block: all reviewsIssues related to the All Reviews block.Issues related to the All Reviews block.block: reviews by categoryIssues related to the Reviews by Category block.Issues related to the Reviews by Category block.block: reviews by productIssues related to the Reviews by Product block.Issues related to the Reviews by Product block.focus: e2e testsIssues related to e2e testsIssues related to e2e tests
Description
Our e2e tests for the Reviews blocks didn't catch woocommerce/woocommerce-blocks#11912. That's because they test for selectors like .wc-block-review-list .wc-block-review-list-item__item:not(.is-loading) to verify the block rendered properly in the editor, but an element matching that selector is rendered even if the Rest API returns an error.
Ideally, our tests should check that the block finished loading and is showing a real review, so instead of checking for a selector, they should probably check for the review text to be displayed.
We could also take the chance to rewrite the tests in Playwright.
Metadata
Metadata
Assignees
Labels
KirigamiWC Store Editing (FSE)WC Store Editing (FSE)block: all reviewsIssues related to the All Reviews block.Issues related to the All Reviews block.block: reviews by categoryIssues related to the Reviews by Category block.Issues related to the Reviews by Category block.block: reviews by productIssues related to the Reviews by Product block.Issues related to the Reviews by Product block.focus: e2e testsIssues related to e2e testsIssues related to e2e tests