Check COGS value != 0 instead of > 0 in post migration

Konamiman · Konamiman · commit 450de5d9acc7 · 2025-10-08T09:39:05.000+02:00
diff --git a/plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php b/plugins/woocommerce/src/Internal/DataStores/Orders/OrdersTableDataStore.php
@@ -1690,7 +1690,7 @@ private function migrate_post_record( \WC_Abstract_Order &$order, \WC_Abstract_O
 			// This prevents overwriting valid COGS data with recalculated zero values during sync-on-read.
 			if ( 'cogs_total_value' === $key && $order->has_cogs() && $this->cogs_is_enabled() ) {
 				$hpos_cogs = $order->get_cogs_total_value( 'edit' );
-				if ( $hpos_cogs > 0 && 0.0 === (float) $value ) {
+				if ( 0.0 !== $hpos_cogs && 0.0 === (float) $value ) {
 					continue;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -1690,7 +1690,7 @@ private function migrate_post_record( \WC_Abstract_Order &$order, \WC_Abstract_O`
`1690`	`1690`	`// This prevents overwriting valid COGS data with recalculated zero values during sync-on-read.`
`1691`	`1691`	`if ( 'cogs_total_value' === $key && $order->has_cogs() && $this->cogs_is_enabled() ) {`
`1692`	`1692`	`$hpos_cogs = $order->get_cogs_total_value( 'edit' );`
`1693`		`- if ( $hpos_cogs > 0 && 0.0 === (float) $value ) {`
	`1693`	`+ if ( 0.0 !== $hpos_cogs && 0.0 === (float) $value ) {`
`1694`	`1694`	`continue;`
`1695`	`1695`	`}`
`1696`	`1696`	`}`