Add types to getConfig()

Aljullu · Aljullu · commit 3b133f2c5d35 · 2025-09-12T10:05:06.000+02:00
diff --git a/plugins/woocommerce/client/blocks/assets/js/atomic/blocks/product-elements/frontend.ts b/plugins/woocommerce/client/blocks/assets/js/atomic/blocks/product-elements/frontend.ts
@@ -9,7 +9,10 @@ import {
 } from '@wordpress/interactivity';
 import '@woocommerce/stores/woocommerce/product-data';
 import type { ProductDataStore } from '@woocommerce/stores/woocommerce/product-data';
-import type { ProductData } from '@woocommerce/stores/woocommerce/cart';
+import type {
+	ProductData,
+	WooCommerceConfig,
+} from '@woocommerce/stores/woocommerce/cart';
 import { sanitizeHTML } from '@woocommerce/sanitize';
 
 // Stores are locked to prevent 3PD usage until the API is stable.
@@ -63,7 +66,9 @@ const productElementStore = store(
 					return undefined;
 				}
 
-				const { products } = getConfig( 'woocommerce' );
+				const { products } = getConfig(
+					'woocommerce'
+				) as WooCommerceConfig;
 
 				if ( ! products ) {
 					return undefined;
diff --git a/plugins/woocommerce/client/blocks/assets/js/base/stores/woocommerce/cart.ts b/plugins/woocommerce/client/blocks/assets/js/base/stores/woocommerce/cart.ts
@@ -9,6 +9,7 @@ import type {
 	ApiErrorResponse,
 	ApiResponse,
 	CartResponseTotals,
+	Currency,
 } from '@woocommerce/types';
 import type {
 	Store as StoreNotices,
@@ -20,6 +21,17 @@ import type {
  */
 import { triggerAddedToCartEvent } from './legacy-events';
 
+export type WooCommerceConfig = {
+	products?: {
+		[ productId: number ]: ProductData;
+	};
+	messages?: {
+		addedToCartText?: string;
+	};
+	placeholderImgSrc?: string;
+	currency?: Currency;
+};
+
 export type SelectedAttributes = Omit< CartVariationItem, 'raw_attribute' >;
 
 export type OptimisticCartItem = {
@@ -386,7 +398,9 @@ const { state, actions } = store< Store >(
 						preserveCartData: true,
 					} );
 
-					const { messages } = getConfig( 'woocommerce' );
+					const { messages } = getConfig(
+						'woocommerce'
+					) as WooCommerceConfig;
 					if ( messages?.addedToCartText ) {
 						wp?.a11y?.speak( messages.addedToCartText, 'polite' );
 					}
@@ -537,7 +551,9 @@ const { state, actions } = store< Store >(
 							preserveCartData: true,
 						} );
 
-						const { messages } = getConfig( 'woocommerce' );
+						const { messages } = getConfig(
+							'woocommerce'
+						) as WooCommerceConfig;
 						if ( messages?.addedToCartText ) {
 							wp?.a11y?.speak(
 								messages.addedToCartText,
diff --git a/plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts b/plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts
@@ -7,6 +7,7 @@ import type {
 	Store as WooCommerce,
 	SelectedAttributes,
 	ProductData,
+	WooCommerceConfig,
 } from '@woocommerce/stores/woocommerce/cart';
 import '@woocommerce/stores/woocommerce/product-data';
 import type { Store as StoreNotices } from '@woocommerce/stores/store-notices';
@@ -74,7 +75,7 @@ export const getProductData = (
 	let productId = id;
 	let productData: ProductData | undefined;
 
-	const { products } = getConfig( 'woocommerce' );
+	const { products } = getConfig( 'woocommerce' ) as WooCommerceConfig;
 
 	if ( selectedAttributes && selectedAttributes.length > 0 ) {
 		if ( ! products || ! products[ id ] ) {
diff --git a/plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts b/plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts
@@ -10,7 +10,10 @@ import {
 	useRef,
 } from '@wordpress/interactivity';
 import '@woocommerce/stores/woocommerce/cart';
-import type { Store as WooCommerce } from '@woocommerce/stores/woocommerce/cart';
+import type {
+	Store as WooCommerce,
+	WooCommerceConfig,
+} from '@woocommerce/stores/woocommerce/cart';
 import Dinero from 'dinero.js';
 
 /**
@@ -26,7 +29,9 @@ import { CartItem, Currency } from '../../types';
 const universalLock =
 	'I acknowledge that using a private store means my plugin will inevitably break on the next store release.';
 
-const { currency, placeholderImgSrc } = getConfig( 'woocommerce' );
+const { currency, placeholderImgSrc } = getConfig(
+	'woocommerce'
+) as WooCommerceConfig;
 const {
 	addToCartBehaviour,
 	onCartClickBehaviour,
@@ -127,6 +132,10 @@ store< MiniCart >(
 			},
 
 			get formattedSubtotal(): string {
+				if ( ! currency ) {
+					return '';
+				}
+
 				const subtotal = displayCartPriceIncludingTax
 					? parseInt( woocommerceState.cart.totals.total_items, 10 ) +
 					  parseInt(
diff --git a/plugins/woocommerce/client/blocks/assets/js/blocks/product-gallery/frontend.ts b/plugins/woocommerce/client/blocks/assets/js/blocks/product-gallery/frontend.ts
@@ -9,6 +9,7 @@ import {
 	getConfig,
 } from '@wordpress/interactivity';
 import type { ProductDataStore } from '@woocommerce/stores/woocommerce/product-data';
+import type { WooCommerceConfig } from '@woocommerce/stores/woocommerce/cart';
 
 /**
  * Internal dependencies
@@ -434,7 +435,9 @@ const productGallery = {
 				return;
 			}
 
-			const { products } = getConfig( 'woocommerce' );
+			const { products } = getConfig(
+				'woocommerce'
+			) as WooCommerceConfig;
 
 			const productData =
 				products?.[ productId ]?.variations?.[
