Skip to content

fix: fix performance issue with adjacent product in 6.9 #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinhtungdu merged 2 commits into from
Dec 9, 2025
Merged

fix: fix performance issue with adjacent product in 6.9 #2202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8697359
fix: fix performance issue with adjacent product in 6.9
dinhtungdu Dec 9, 2025
665ced1
chore: lint
dinhtungdu Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions inc/woocommerce/class-storefront-woocommerce-adjacent-products.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,23 @@ public function filter_post_where( $where ) {

$where = str_replace( $post->post_date, $new->post_date, $where );

/**
* In 6.9, the get_adjacent_post() function uses not only date but also ID to get the
* adjacent post. We need to replace the ID as well to avoid returning the same adjacent
* product when the published date of products is the same.
* We're using simple string replacement instead of regex to have the performance impact
* as minimal as possible and matching the exact clause provided by WordPress.
*
* @see https://github.com/WordPress/wordpress-develop/commit/70ca20bcbb3cbdef483050c4764259324c07359e.
*/
if ( strpos( $where, 'AND p.ID ' ) !== false ) {
$search = sprintf( 'AND p.ID %s ', $this->previous ? '<' : '>' );
$target = $search . $post->ID;
$replace = $search . $new->ID;

$where = str_replace( $target, $replace, $where );
}

return $where;
}

Expand Down
Loading