fix: an issue that crashes when cancel is not present#852
Merged
wonday merged 1 commit intowonday:masterfrom Nov 18, 2024
Merged
fix: an issue that crashes when cancel is not present#852wonday merged 1 commit intowonday:masterfrom
wonday merged 1 commit intowonday:masterfrom
Conversation
Contributor
Author
|
@wonday could you please merge this asap, it's a simple change yet it crashes apps in production, I have to manually change it in node_modules every time a |
|
@ajakka you can use patch-package to apply your fix locally after every |
Contributor
Author
|
@wise-danya Thank you, this helps a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where the user swipes multiple pdf files, and when the pdf is still loading and user swipes it, the cancel function get fired before its initialized. I fixed it by checking if the cancel function exists before calling it.