Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talbot Gooday's AndroidPdfViewer library hasn't received updates in years and never updated the underlying native PDFium library.
PdfiumAndroidKt is a successor to PdfiumAndroid, rewritten in Kotlin, and with updated native libraries. It's also being actively maintained.
This PR changes the AndroidPdfViewer dependency to my fork, which depends on PdfiumAndroidKt instead of PdfiumAndroid. I also added a direct dependency here to PdfiumAndroidKt so that it can be updated alongside PdfiumAndroidKt without needing to modify AndroidPdfViewer first.
I also did a little cleanup in the Gradle config and in PdfView.
My fork of AndroidPdfViewer comes with similar caveats to Talbot Gooday's in that I don't plan on maintaining it. However, I will be monitoring pull requests for features and bugfixes, and since PdfiumAndroidKt is doing most of the heavy lifting, AndroidPdfViewer shouldn't need many updates.