add an option for disabling double tap#797
Conversation
|
I need this option, can we have it merged??? |
|
It is cool, but can you modify the readme file together? |
|
Readme updated |
|
This change effectively breaks link detection on iOS due to the disabling of the I currently work around this by disabling |
|
I would suggest creating a pull request against react-native-pdf |
|
@tobyt42 I've opened an issue. Since I don't know the exact reasoning behind introducing the My patch just comments out the disabling of the tap gesture recognizer & since I don't think I need the |
4 participants
Double tap remains enabled by default but can be optionally disabled.
This is based on a patch that was posted on this issue #528, which I've made minor adjustments to whenever I needed to apply it to a newer react-native-pdf version.
Some users of my app have reported that they accidentally activate zoom without double tapping (it seems to be an issue on some devices only), hence I have used this patch to give users the option to disable double-tap zooming. Setting maxScale to 1 as reported on the linked issue, did not help with the issue for me.