Fix non-power-of-two texture mip size#43
Merged
wolfpld merged 1 commit intowolfpld:masterfrom Nov 10, 2024
zeux:fix-npot
Merged
Fix non-power-of-two texture mip size#43wolfpld merged 1 commit intowolfpld:masterfrom zeux:fix-npot
wolfpld merged 1 commit intowolfpld:masterfrom
zeux:fix-npot
Conversation
Non-power-of-two textures eventually get a mip dimension that isn't divisible by 4; the length computation didn't properly round that to block boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-power-of-two textures eventually get a mip dimension that isn't divisible by 4; the length computation didn't properly round that to block boundaries.
Note: there is still some faulty logic in DataProvider.cpp that misbehaves for NPOT textures, so this doesn't fully fix the case when mips are generated; that would require a separate fix to the downsampling logic (ideally including masking off parts of the NPOT mips that are not used...)