Add HAVE_GETPID to options.h if getpid detected#8898
Merged
dgarske merged 3 commits intowolfSSL:masterfrom Jun 24, 2025
Merged
Conversation
…orrectly detect size of WC_RNG struct
dgarske
previously approved these changes
Jun 18, 2025
…bundles that do not have older random.c files
Member
Author
|
Retest this please Jenkins |
dgarske
previously approved these changes
Jun 23, 2025
Contributor
|
Retest this please Jenkins. Made a change now for PRB-fips-ready-config to account for HAVE_GETPID macro define when creating the user_settings.h file to test with. |
Contributor
|
We need this PR merged. Worked with Aidan to debug an issue with wolfProvider that turned out to be the same WC_RNG size issue corrupting memory due to struct size mismatch. Multiple engineers have each wasted multi hours because of this change. |
JacobBarthelmeh
approved these changes
Jun 24, 2025
dgarske
approved these changes
Jun 24, 2025
Contributor
|
Merging before prb master finishes. Thank you Chris and Jacob |
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Jan 16, 2026
Details: https://nvd.nist.gov/vuln/detail/CVE-2025-7394 Backport patches from the PR[1][2][3] mentioned in the changelog[4]. [1] wolfSSL/wolfssl#8849 [2] wolfSSL/wolfssl#8867 [3] wolfSSL/wolfssl#8898 [4] https://github.com/wolfSSL/wolfssl/blob/master/ChangeLog.md#wolfssl-release-582-july-17-2025 Signed-off-by: Ankur Tyagi <[email protected]> Signed-off-by: Anuj Mittal <[email protected]>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/meta-openembedded
that referenced
this pull request
Jan 20, 2026
Source: meta-openembedded MR: 302820 Type: Integration Disposition: Merged from meta-openembedded ChangeID: c49bff1 Description: Details: https://nvd.nist.gov/vuln/detail/CVE-2025-7394 Backport patches from the PR[1][2][3] mentioned in the changelog[4]. [1] wolfSSL/wolfssl#8849 [2] wolfSSL/wolfssl#8867 [3] wolfSSL/wolfssl#8898 [4] https://github.com/wolfSSL/wolfssl/blob/master/ChangeLog.md#wolfssl-release-582-july-17-2025 Signed-off-by: Ankur Tyagi <[email protected]> Signed-off-by: Anuj Mittal <[email protected]> Signed-off-by: Jeremy A. Puhlman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #8867 added use of
getpid(), and also adjusted the definition ofWC_RNGinwolfssl/wolfcrypt/random.hbased onHAVE_PID:The
HAVE_GETPIDdefine was not being stored towolfssl/options.h, so applications depending on thesizeof(WC_RNG)would have gotten a different structure size.This PR modifies
configure.acto defineHAVE_GETPIDinwolfssl/options.hifgetpid()is detected.Testing
Existing unit tests, and wolfcrypt-jni test cases.
Checklist