Skip to content

Apply pep8 and pyflakes#11

Closed
hugovk wants to merge 1 commit intowolever:masterfrom
hugovk:pep8
Closed

Apply pep8 and pyflakes#11
hugovk wants to merge 1 commit intowolever:masterfrom
hugovk:pep8

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented May 4, 2014

pep8 is for style.
pyflakes finds programming errors.
Also report after successful Travis jobs.

@wolever
Copy link
Owner

wolever commented May 4, 2014

Sorry, but I don't want my Travis build failing because of stylistic errors. Additionally, I'm not a huge fan of all of the pep8/pyflakes changes. If you want to have the checks, though, feel free to add them to tox.ini file: http://www.dominicrodger.com/tox-and-travis.html and disable the whitespace-related checks.

@hugovk
Copy link
Contributor Author

hugovk commented May 5, 2014

OK, no problem!

These things won't cause any Travis failures. They're just reported at the end of an already successful build.

pep8 is just style, but pyflakes is worth keeping an eye on as it can show logical errors like referring to undefined variables.

Anyway, I've never used tox before, I'll look into it.

@hugovk hugovk closed this May 5, 2014
wolever pushed a commit that referenced this pull request Apr 14, 2022
`isort` and `black` applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants