Move CTT calculation from BusPwm to Bus class.#3293
Closed
Robert-github-com wants to merge 2 commits intowled:mainfrom
Closed
Move CTT calculation from BusPwm to Bus class.#3293Robert-github-com wants to merge 2 commits intowled:mainfrom
Robert-github-com wants to merge 2 commits intowled:mainfrom
Conversation
blazoncek
reviewed
Jul 17, 2023
Contributor
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
Apart from minor suggestions all seems fine.
Closed
added 2 commits
July 31, 2023 00:23
This enable it to other bus types.
…CTT protected member.
Contributor
|
Please do not force push changes in the future. |
|
@blazoncek With the merge of #3810, this can now be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enable it to other bus types.
Need for adding RGBWW LEDs on digital bus.