fix(android): enable kotlin 2.x compatibility w/opt-in for .entries usage
#4817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosha212
approved these changes
Aug 15, 2025
Contributor
|
Amazing |
Contributor
Author
|
Wow that was fast :-). Thanks for Detox, we do appreciate it |
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Aug 15, 2025
this has been merged and this patch may be dropped whenever it is released See wix/Detox#4817
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Aug 16, 2025
this has been merged and this patch may be dropped whenever it is released See wix/Detox#4817
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Aug 18, 2025
this has been merged and this patch may be dropped whenever it is released See wix/Detox#4817
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Aug 18, 2025
this has been merged and this patch may be dropped whenever it is released See wix/Detox#4817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kotlin 2.x appears to require an opt-in for the use of
.entries, this has been logged for some time, this PR will fix it:There was an existing PR that also fixed this - and was in fact used by react-native-firebase's e2e project via patch-package but it had unaddressed feedback from @gosha212 and was closed stale:
That's a good point. So I tried that locally and it seemed to work, and now I propose it here.