Skip to content

fix: CUDA context creation#285

Merged
giladgd merged 3 commits intobetafrom
gilad/bugFixes4
Aug 2, 2024
Merged

fix: CUDA context creation#285
giladgd merged 3 commits intobetafrom
gilad/bugFixes4

Conversation

@giladgd
Copy link
Copy Markdown
Member

@giladgd giladgd commented Aug 2, 2024

Description of change

  • fix: CUDA context creation
  • fix: detokenizer unpredictable text length

Fixes #283
Fixes #282

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto August 2, 2024 16:17
@giladgd giladgd self-assigned this Aug 2, 2024
@giladgd giladgd mentioned this pull request Aug 2, 2024
Closed
3 tasks
ido-pluto
ido-pluto approved these changes Aug 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit a2b2bc3 into beta Aug 2, 2024
@giladgd giladgd deleted the gilad/bugFixes4 branch August 2, 2024 16:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 2, 2024

🎉 This PR is included in version 3.0.0-beta.41 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2024 •
edited by giladgd
Loading

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels

released on @beta released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giladgd @ido-pluto