Add 5.0 Actions Middleware change#9943
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
It looks great! I have nothing to say about the content, everything seems clear to me. 💯
I just left some suggestions regarding:
- absolute > relative URL (the link check script does not run on PRs targeting beta branch, but will throw errors once merged)
- a missing type I think
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Didn't want to lose this review as the PR is refreshing underneath me, so here's a partial review not yet looking at the API reference file!
(All great stuff here Ben, and only very minor polishing things and some suggestions in case they work.)
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
|
Alright, that's all the edits for guides! And it sounds like you're pretty thorough with API reference reviews @ArmandPhilippot. If there are any no-brainer fixes, feel free to commit changes directly to the branch. Won't have as much time to review myself so just want to avoid too much "commit suggestion" back and forth 😄 |
sarah11918
added
add new content
Co-authored-by: Armand Philippot <[email protected]>
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thanks @bholmesdev ! Did my pass on the API reference page and just a few quick things for you to scan/confirm/improve!
Once you're happy with that, this will be fine to merge into beta docs, and Chris and I may yet do a little more overall polish (with everything!) before stable 5, but you won't need to feel those little papercuts!
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
|
Not the biggest deal @bholmesdev , but I don't think this has actually been released on beta yet, so the docs are live there now but your feature isn't. 😅 Let me check to see when platform is scheduled to release! |
This reverts commit 6245c70.
3 participants
Description (required)
This introduces the new default when submitting Actions from an HTML form. We've removed the cookie forwarding default and introduced a new
getActionContext()utility to customize how actions are handled using middleware.getActionContext()patterngetActionContext()API referenceRelated issues & labels (optional)
For Astro version:
5.0. See astro PR #12373.