Skip to content

guide: ISR | Incremental Static Regeneration#3527

Closed
lilnasy wants to merge 14 commits into
withastro:mainfrom
lilnasy:main
Closed

guide: ISR | Incremental Static Regeneration#3527
lilnasy wants to merge 14 commits into
withastro:mainfrom
lilnasy:main

Conversation

@lilnasy

@lilnasy lilnasy commented Jun 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented Jun 19, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9fb1fe7
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/652d56a4697ea40008e75bea
😎 Deploy Preview https://deploy-preview-3527--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 20, 2023
@lilnasy lilnasy added the help wanted Issues looking for someone to run with them! label Jul 20, 2023
@Alynva

Alynva commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

I think that you should remove the else block (keep it's content), so when you remove the stale cache, it still runs that code

@lilnasy

lilnasy commented Jul 25, 2023

Copy link
Copy Markdown
Contributor Author

@Alynva which else do you mean? Could you make a comment in the diff?

Alynva
Alynva suggested changes Jul 25, 2023
View reviewed changes

@Alynva Alynva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilnasy Sorry, I was on mobile. I've added the suggestions now

Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx Outdated
Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx Outdated
@delucis delucis mentioned this pull request Aug 17, 2023
Closed
1 task
dreyfus92
dreyfus92 requested changes Aug 29, 2023
View reviewed changes

@dreyfus92 dreyfus92 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these fixes might help @lilnasy

Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx Outdated
Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx Outdated
@lilnasy
lilnasy marked this pull request as ready for review August 30, 2023 13:08
artmsv
artmsv reviewed Aug 30, 2023
View reviewed changes
Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx Outdated
dreyfus92
dreyfus92 requested changes Aug 30, 2023
View reviewed changes

@dreyfus92 dreyfus92 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if having new lines in between is intentional to improve readibility. If not I leave this minor suggestion @lilnasy.

Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx
artmsv
artmsv reviewed Sep 7, 2023
View reviewed changes
Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx
@theotterlord

theotterlord commented Nov 15, 2023

Copy link
Copy Markdown
Member

Heads up!
We've just migrated the docs site from Netlify to Vercel. With that, the Netlify app has been removed, and will no longer update deploy previews. Vercel should post a comment with the new deploy preview the next time this PR is updated.

@sarah11918 sarah11918 added the help - leave feedback Let's crowd source this one! Looking for comments, suggestions, LGTMs! label Nov 24, 2023
lilnasy and others added 12 commits December 5, 2023 16:07
@lilnasy
jumping off point
7974321
@lilnasy
Add API route example, netlify config
96317fc
@lilnasy
grammar, more comments, more notes
5138397
@lilnasy
why ISR, why not ISR
6c80c31
@lilnasy @Alynva
Update incremental-static-regeneration.mdx
50fb72a 
Co-authored-by: Alisson Nunes <[email protected]>
@lilnasy @Alynva
Updateincremental-static-regeneration.mdx
001b6c6 
Co-authored-by: Alisson Nunes <[email protected]>
@lilnasy
with hybrid output
77f0eb4
@lilnasy
update netlify, add cache-control explainer
6eddc03
@lilnasy @dreyfus92
Apply suggestions from code review
149a5c8 
Co-authored-by: Paul Valladares <[email protected]>
@lilnasy
ready for review
c18ab03
@lilnasy @artmsv
Update src/content/docs/en/guides/incremental-static-regeneration.mdx
c9c0e12 
Co-authored-by: Artem Savelev <[email protected]>
@lilnasy @dreyfus92
Update src/content/docs/en/guides/incremental-static-regeneration.mdx
728bca7 
Co-authored-by: Paul Valladares <[email protected]>
@vercel

vercel Bot commented Dec 5, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 22, 2023 4:01pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 4:01pm

sarah11918
sarah11918 reviewed Dec 22, 2023
View reviewed changes
Comment thread src/content/docs/en/guides/incremental-static-regeneration.mdx Outdated
@vercel

vercel Bot commented Dec 22, 2023

Copy link
Copy Markdown

@sarah11918 is attempting to deploy a commit to the Astro Team on Vercel.

A member of the Team first needs to authorize it.

@sarah11918

sarah11918 commented Dec 23, 2023

Copy link
Copy Markdown
Member

🫡

@sarah11918 sarah11918 closed this Dec 23, 2023
@selrond

selrond commented Jan 13, 2024

Copy link
Copy Markdown

Why was this closed?

@lilnasy

lilnasy commented Jan 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@selrond It was just sitting in the backlog for too long. We may still revisit this.

Although, a well-edited version of this was published as a blog post on logsnag! You may want check that out.

https://logsnag.com/blog/implementing-isr-in-astro

@aretrace

aretrace commented Jan 27, 2024

Copy link
Copy Markdown

This information should be included in the docs. Astro is particularly attractive for projects that would also happen to greatly benefit from this technique.

@oemer-aran

oemer-aran commented May 6, 2024

Copy link
Copy Markdown

I would also add this to the official docs. It includes deployment details for different hosting services, which are very valuable. Also reading from the official docs conveys more trust than a blog post. I read through the posts on Logsnag. They were really insightful and very well written. But the code is more like a POC (a very good one), which could potentially be extended with real cache providers.

On-Demand Revalidation would really be a killer feature with astro.js. It's the only real missing piece for me. Especially if you want to serve live data from a CMS which has a API request limit, like Sanity.

@Raik410

Raik410 commented Nov 1, 2025

Copy link
Copy Markdown

Please add this to the official documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments
@dreyfus92 dreyfus92 dreyfus92 approved these changes
+2 more reviewers
@artmsv artmsv artmsv left review comments
@Alynva Alynva Alynva requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. help - leave feedback Let's crowd source this one! Looking for comments, suggestions, LGTMs! help wanted Issues looking for someone to run with them!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@lilnasy @Alynva @theotterlord @sarah11918 @selrond @aretrace @oemer-aran @Raik410 @artmsv @dreyfus92