Remove deprecated remarkPlugins references from "last modified" recipe#14029
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
| import { remarkModifiedTime } from './remark-modified-time.mjs'; | ||
|
|
||
| export default defineConfig({ | ||
| markdown: { |
There was a problem hiding this comment.
One thing that tripped me up here: I followed the recipe as-is and last updated wasn't showing up. Wasn't sure why, then discovered that mdx requires putting the processor somewhere else. Maybe worth calling out? https://docs.astro.build/en/guides/markdown-content/#modifying-frontmatter-programmatically
There was a problem hiding this comment.
I'm not sure I understand. Do you mean, you had to add something special so it works with MDX? If so, it sounds like a bug. IIUC, MDX should inherit from Markdown config by default!
If you refer to step 2 in your link... Maybe this is more confusing than helpful currently. The "or" is, AFAIK, if you want to use a different configuration for MDX. But, I can understand the confusion here!
(This was originally planned for v7, but we changed our minds at the last minute so people had the chance to try it… The docs may have been written a little hastily. 😅 Thanks for your feedback!)
There was a problem hiding this comment.
Oh, interesting. I initially put the config within the markdown config option, but it didn't output anything to the frontmatter for my mdx files.
I had to relocate the processor config within the mdx() integration to get it to work.
There was a problem hiding this comment.
Oh, weird. Thanks for the clarification! Maybe I misunderstood or maybe there is a bug here. I'll see if I can find more info before we merge this!
There was a problem hiding this comment.
Okay, so, it seems MDX should indeed inherit from markdown. config (unless you disable extendMarkdownOptions). If this doesn't work, it sounds like a bug and a minimal repro reported to withastro/astro could be helpful!
There was a problem hiding this comment.
I'll try to dig in a bit more!
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you! 💜
I left a nit for the first step, let me know what you think of it. I'm not approving yet because I'm not sure I understand your last comment (see my reply), but overall this looks good to me!
| import { remarkModifiedTime } from './remark-modified-time.mjs'; | ||
|
|
||
| export default defineConfig({ | ||
| markdown: { |
There was a problem hiding this comment.
I'm not sure I understand. Do you mean, you had to add something special so it works with MDX? If so, it sounds like a bug. IIUC, MDX should inherit from Markdown config by default!
If you refer to step 2 in your link... Maybe this is more confusing than helpful currently. The "or" is, AFAIK, if you want to use a different configuration for MDX. But, I can understand the confusion here!
(This was originally planned for v7, but we changed our minds at the last minute so people had the chance to try it… The docs may have been written a little hastily. 😅 Thanks for your feedback!)
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks for your help! 🙌🏽
* main: i18n(ko-KR): update `cosmic`, `markdown-content`, `modified-time` (#14041) i18n(pt-br): Update editor-setup.mdx translation (#14040) i18n(it-IT): create it/guides/fonts.mdx (#13871) i18n(fr): update `guides/astro-db.mdx` & `integrations-guide/db.mdx` (#14033) i18n(fr): update `guides/markdown-content.mdx` (#14034) i18n(fr): update `recipes/modified-time.mdx` (#14035) i18n(fr): update `session-driver-reference.mdx` (#14036) Remove a broken theme in Cosmic (#14039) Remove stale themes and production sites on 3rd party guides [i18nIgnore] (#14038) Remove deprecated `remarkPlugins` references from "last modified" recipe (#14029) Fix incorrect code examples in the Markdown guide (#14032) i18n(ko-KR): update `db`, `astro-db`, `github`, `session-driver-reference` (#14031) Deprecate `@astrojs/db` (#13986)
…ipe (withastro#14029) Co-authored-by: Armand Philippot <[email protected]>
3 participants
Description
This updates the modified time recipe to remove references to the now-deprecated
remarkPluginsconfig option.Related issues & labels
No existing issue