Skip to content

feat: add mention of possibility of perhaps async in the file() loader#13108

Merged
sarah11918 merged 4 commits into5.17.0from
feat/parser-async
Jan 27, 2026
Merged

feat: add mention of possibility of perhaps async in the file() loader#13108
sarah11918 merged 4 commits into5.17.0from
feat/parser-async

Conversation

@Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jan 23, 2026

Description (required)

For withastro/astro#14932. The parser function can now be async, which is pretty neat if you want to fetch files every time you parse your .csv (maybe don't do that)

@netlify
Copy link

netlify bot commented Jan 23, 2026 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 246eb04
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69791a94d5894d0008fee575
😎 Deploy Preview https://deploy-preview-13108--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 23, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/content-collections.mdx Source changed, localizations will be marked as outdated.
en/reference/content-loader-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Princesseuh Princesseuh mentioned this pull request Jan 23, 2026
Merged
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jan 23, 2026
sarah11918
sarah11918 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just what we needed! 🫡

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 23, 2026
@sarah11918 sarah11918 added this to the 5.17.0 milestone Jan 23, 2026
@sarah11918
Copy link
Member

sarah11918 commented Jan 23, 2026

Oops, forgot that the reference entry for parser() at docs.astro.build/en/reference/content-loader-reference#parser needs updating (both in current docs and in v6 docs) to now show that this can be async.

I think @ArmandPhilippot suggested what this needs to look like in the other PR? withastro/astro#14932 (comment)

@ArmandPhilippot
Copy link
Member

ArmandPhilippot commented Jan 23, 2026

Yes, we would need to update the type with:

(text: string) => Record<string, Record<string, unknown>> | Array<Record<string, unknown>> | Promise<Record<string, Record<string, unknown>> | Array<Record<string, unknown>>>

to show in the reference that the parser can be async.

@sarah11918
Copy link
Member

sarah11918 commented Jan 26, 2026

Just noting that we still need someone to make the change Armand has suggested above! (Y'all really gonna make me open Firebase Studio for this.... 😆 )

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 26, 2026
sarah11918
sarah11918 approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone! Ready for the release (for realz this time!)

@sarah11918 sarah11918 changed the base branch from main to 5.17.0 January 27, 2026 20:07
@sarah11918 sarah11918 mentioned this pull request Jan 27, 2026
Merged
@sarah11918 sarah11918 merged commit c3c2cae into 5.17.0 Jan 27, 2026
6 checks passed
@sarah11918 sarah11918 deleted the feat/parser-async branch January 27, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!

Projects

None yet

Milestone

5.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Princesseuh @astrobot-houston @sarah11918 @ArmandPhilippot