Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
delucis
left a comment
There was a problem hiding this comment.
Thanks @florian-lefebvre! Changes seem fine to me. I left some comments, but then realised I maybe had a future idea of the API in mind from our discussions and not actually what is implemented, so maybe my comments would only make sense for the future rather than now.
|
I think the comments about the local provider make sense but yeah it indeed isn't the right PR for them. So I'm gonna mark them as resolved for this PR and look at them when I unify providers later on this week or next week |
sarah11918
left a comment
There was a problem hiding this comment.
Looks great @florian-lefebvre ! Just left a few comments!
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
left a comment
There was a problem hiding this comment.
Just updated your suggestion to incorporate new and old, and I think it works! If you're happy, I'm happy!
| - [Google Icons](#google-icons) | ||
|
|
||
| To use a built-in remote provider, configure `provider` with the appropriate value for your chosen font provider: | ||
| To use a built-in remote provider, import `fontProviders` and configure [`provider`](#provider) with the appropriate value for your chosen font provider: |
There was a problem hiding this comment.
Oh, I see what you mean now! the GitHub diff looked off. Sorry, I see this now! OK, lemme suggest fresh now.
Co-authored-by: Sarah Rainsberger <[email protected]>
Description (required)
Related issues & labels (optional)
For Astro version:
5.16.10. See astro PR #15175.