Skip to content

feat(fonts): family options#13037

Merged
florian-lefebvre merged 7 commits intomainfrom
feat/fonts-family-options
Jan 21, 2026
Merged

feat(fonts): family options#13037
florian-lefebvre merged 7 commits intomainfrom
feat/fonts-family-options

Conversation

@florian-lefebvre
Copy link
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.16.10. See astro PR #15175.

@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 69d06b8
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6970d1e967cca80008496723
😎 Deploy Preview https://deploy-preview-13037--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 12, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @florian-lefebvre! Changes seem fine to me. I left some comments, but then realised I maybe had a future idea of the API in mind from our discussions and not actually what is implemented, so maybe my comments would only make sense for the future rather than now.

@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Jan 14, 2026

I think the comments about the local provider make sense but yeah it indeed isn't the right PR for them. So I'm gonna mark them as resolved for this PR and look at them when I unify providers later on this week or next week

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @florian-lefebvre ! Just left a few comments!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jan 20, 2026
Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated your suggestion to incorporate new and old, and I think it works! If you're happy, I'm happy!

- [Google Icons](#google-icons)

To use a built-in remote provider, configure `provider` with the appropriate value for your chosen font provider:
To use a built-in remote provider, import `fontProviders` and configure [`provider`](#provider) with the appropriate value for your chosen font provider:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see what you mean now! the GitHub diff looked off. Sorry, I see this now! OK, lemme suggest fresh now.

@florian-lefebvre florian-lefebvre merged commit ca3dcc6 into main Jan 21, 2026
10 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-family-options branch January 21, 2026 13:51
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants