[next]: add migration section for removal of internal exports#12816
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thanks for providing these docs @trueberryless , and really nice editing job @florian-lefebvre ! I just left a couple of thoughts here.
(And note: the order of these entries got a little bit messed up. I've been trying to keep the core breaking changes FIRST, and then the ones that are likely to affect fewer people (e.g. Adapter API, Integration API) at the end, with their API in parentheses.
So ideally I'd probably order this one higher, before any of the Integration/Adapter ones. But, there are more that will need to be reordered, so not a huge deal to do that in this PR. Ideally though, these should not just "go to the bottom of the list" but go in "relevance" order, so that the average person sees the more basic stuff first (and can maybe stop reading at some point).
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
|
Thanks for the reviews and amazing suggestions, Sarah and Florian! I really like the |
4 participants
Description (required)
This PR adds a section to the v6 migration guide regarding refactor: cleanup public actions API #14844 .
I listed all removed utilities (classes, functions and types) for clarity. I'm not sure if this is a good approach, as when people search for these terms in the future, they'll be able to find them here, alto they are not documented anywhere (because they got removed).
I did not come up with a better example to demonstrate a removal and I was so cheeky to include myself in there. Feel free to suggest a more appropriate example 🙌
Related issues & labels (optional)
For Astro version:
6.x. See astro PR #14844.Pinging @florian-lefebvre for review (no rush!).