Skip to content

[v6] disallow number in getStaticPaths params#12608

Merged
florian-lefebvre merged 10 commits into
withastro:v6from
ocavue-forks:ocavue/rm-static-path-num
Oct 27, 2025
Merged

[v6] disallow number in getStaticPaths params#12608
florian-lefebvre merged 10 commits into
withastro:v6from
ocavue-forks:ocavue/rm-static-path-num

Conversation

@ocavue

@ocavue ocavue commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description (required)

v6 docs for the upcoming breaking change introduced in withastro/astro#14586

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify

netlify Bot commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 52a7271
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68ff2c3bda366800085e305c
😎 Deploy Preview https://deploy-preview-12608--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston

astrobot-houston commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ocavue
ocavue marked this pull request as ready for review October 23, 2025 13:19
@ocavue ocavue mentioned this pull request Oct 23, 2025
Merged
florian-lefebvre
florian-lefebvre reviewed Oct 24, 2025
View reviewed changes
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx
@sarah11918 sarah11918 added the 6.0 label Oct 24, 2025
sarah11918
sarah11918 reviewed Oct 24, 2025
View reviewed changes

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of Florian's suggestions look great to me! (I did do some tiny polishing edits)

florian-lefebvre
florian-lefebvre approved these changes Oct 24, 2025
View reviewed changes
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
yanthomasdev
yanthomasdev approved these changes Oct 24, 2025
View reviewed changes

@yanthomasdev yanthomasdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ArmandPhilippot
ArmandPhilippot approved these changes Oct 24, 2025
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two nits (indentation and link format), otherwise LGTM!

Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx
Comment thread src/content/docs/en/guides/upgrade-to/v6.mdx Outdated
bjohansebas
bjohansebas approved these changes Oct 25, 2025
View reviewed changes

@bjohansebas bjohansebas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarah11918
sarah11918 approved these changes Oct 27, 2025
View reviewed changes

@sarah11918 sarah11918 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thank you, and welcome to Team Docs @ocavue ! 🥳

@florian-lefebvre
florian-lefebvre merged commit 5d03bde into withastro:v6 Oct 27, 2025
6 checks passed
@sarah11918 sarah11918 added this to the v6.0.0 docs milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes
@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes
@yanthomasdev yanthomasdev yanthomasdev approved these changes
@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.0

Projects

None yet

Milestone

v6.0.0 docs

Development

Successfully merging this pull request may close these issues.

7 participants

@ocavue @astrobot-houston @sarah11918 @ArmandPhilippot @yanthomasdev @florian-lefebvre @bjohansebas